Skip to content

test(nuxt): Add test for distributed client-to-server request #16788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 2, 2025

While working on route parametrization, it came up in this PR that there are different transactions/spans which should be parametrized:

  • pageload transaction -> it's already parametrized because of the vueIntegration
  • SSR http.server transaction -> not parametrized
  • http.client span when doing an extra server request -> not parametrized
  • http.server span when doing an extra server request -> not parametrized

This test is added to have a visualization of the current state of parametrization to be able to iterate on it.

The PR is quite long but the test case and the tests are just copy-pasted to all Nuxt E2E tests.

cursor[bot]

This comment was marked as outdated.

@s1gr1d s1gr1d force-pushed the sig/improve-nuxt-tests branch from 77bbd04 to 6c89f3b Compare July 7, 2025 11:24
@s1gr1d s1gr1d changed the title test(nuxt): Add test for distributed server request test(nuxt): Add test for distributed client-to-server request Jul 7, 2025
@s1gr1d s1gr1d force-pushed the sig/improve-nuxt-tests branch from 21078dc to 2be99a2 Compare July 7, 2025 12:20
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left the comments on the first test but I this applies to all of them basically.

Rest LGTM!

@s1gr1d s1gr1d merged commit 868d01a into develop Jul 8, 2025
141 checks passed
@s1gr1d s1gr1d deleted the sig/improve-nuxt-tests branch July 8, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants